[Credo][Ycable] Fix for displaying 'N/A' firmware version when NIC endpoint is power off #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are version of the self-side when the NIC end is power off Signed-off-by: Xinyu <xinyu0123@gmail.com>
|
@xinyulin can you paste the CLI output with this fix |
prgeor
previously approved these changes
Apr 25, 2023
Sure!, added in the description. |
vdahiya12
reviewed
May 23, 2023
sonic_y_cable/credo/y_cable_credo.py
Outdated
| self.log_error('Get firmware version error (error code:0x%04X)' % (status)) | ||
| return None | ||
| ''' should at least return local side fw version if nic is offline''' | ||
| if status == 0x1A and ((read_side[0] == 4 and target == 1) or (read_side[0] == 2 and target == 2)): |
There was a problem hiding this comment.
can the read_side byr array be empty ?
if yes we could be causing exception here.
There was a problem hiding this comment.
Yes, I'd better to call get_read_side() to handle all the exceptions. I will submit a commit to fix it, thanks!
Signed-off-by: Xinyu <xinyu0123@gmail.com>
vdahiya12
approved these changes
Jun 5, 2023
vdahiya12
approved these changes
Jun 5, 2023
|
LGTM, |
prgeor
reviewed
Sep 13, 2023
sonic_y_cable/credo/y_cable_credo.py
Outdated
| self.log_error('Get firmware version error (error code:0x%04X)' % (status)) | ||
| return None | ||
| ''' should at least return local side fw version if nic is offline''' | ||
| if status == 0x1A and (read_side == target): |
There was a problem hiding this comment.
@xinyulin 0x1A can you name this status value
There was a problem hiding this comment.
Sure, I made the correction in the last commit. Please review it.
… for readability Signed-off-by: Xinyu <xinyu0123@gmail.com>
prgeor
approved these changes
Sep 19, 2023
StormLiangMS
pushed a commit
that referenced
this pull request
Sep 21, 2023
…dpoint is power off (#366) * [Credo][Ycable] Resolve the issue of being unable to obtain the firmware version of the self-side when the NIC end is power off Signed-off-by: Xinyu <xinyu0123@gmail.com> * [Credo][Ycable] call get_read_side() to handle exceptions Signed-off-by: Xinyu <xinyu0123@gmail.com> * [Credo][Ycable] Replace the hard-coded value with a constant variable for readability Signed-off-by: Xinyu <xinyu0123@gmail.com> --------- Signed-off-by: Xinyu <xinyu0123@gmail.com> Co-authored-by: Prince George <45705344+prgeor@users.noreply.github.com>
mssonicbld
pushed a commit
to mssonicbld/sonic-platform-common
that referenced
this pull request
Jan 25, 2024
…dpoint is power off (sonic-net#366) * [Credo][Ycable] Resolve the issue of being unable to obtain the firmware version of the self-side when the NIC end is power off Signed-off-by: Xinyu <xinyu0123@gmail.com> * [Credo][Ycable] call get_read_side() to handle exceptions Signed-off-by: Xinyu <xinyu0123@gmail.com> * [Credo][Ycable] Replace the hard-coded value with a constant variable for readability Signed-off-by: Xinyu <xinyu0123@gmail.com> --------- Signed-off-by: Xinyu <xinyu0123@gmail.com> Co-authored-by: Prince George <45705344+prgeor@users.noreply.github.com>
|
Cherry-pick PR to 202205: #430 |
mssonicbld
pushed a commit
that referenced
this pull request
Jan 25, 2024
…dpoint is power off (#366) * [Credo][Ycable] Resolve the issue of being unable to obtain the firmware version of the self-side when the NIC end is power off Signed-off-by: Xinyu <xinyu0123@gmail.com> * [Credo][Ycable] call get_read_side() to handle exceptions Signed-off-by: Xinyu <xinyu0123@gmail.com> * [Credo][Ycable] Replace the hard-coded value with a constant variable for readability Signed-off-by: Xinyu <xinyu0123@gmail.com> --------- Signed-off-by: Xinyu <xinyu0123@gmail.com> Co-authored-by: Prince George <45705344+prgeor@users.noreply.github.com>
mssonicbld
added
Included in 202205 Branch
and removed
Created PR to 202205 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix resolve the issue of being unable to obtain the firmware version of the self-side when the NIC end is power off.
Motivation and Context
To report the self-side firmware version for maintenance and trouble shooting.
How Has This Been Tested?
Tested on Arista-7050CX3
The original version will show 'N/A' for all endpoints If the NIC endpoint is turned off,
After applying the fix, the self-tor version can be displayed correctly.
Additional Information (Optional)