[bfd] BFD HW offload for BGP sessions #1599
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial version, a proposal for BFD hardware offload for BGP sessions
|
@baorliu , please follow the template for the description and list all associated PRs. Will assign the reviewers |
kperumalbfn
reviewed
Sep 26, 2024
| |--------------------------|--------------------------------| | ||
| | BFD_SESSION_DEFAULT_TX_INTERVAL | 300 millisecond | | ||
| | BFD_SESSION_DEFAULT_RX_INTERVAL | 300 millisecond | | ||
| | BFD_SESSION_DEFAULT_DETECT_MULTIPLIER | 3 | |
There was a problem hiding this comment.
Can you include BFD CRM to account total/available/used BFD hardware resource?
| Here is an example to configure it in config_db: | ||
|
|
||
| /etc/sonic/config_db.json | ||
| ``` |
There was a problem hiding this comment.
Can this be enabled through 'config feature state' CLI? If so, could you add yang model changes as well.
| * structures lookup. | ||
| */ | ||
| struct bfddp_session { | ||
| /** Important session flags. \see bfddp_session_flag. */ |
There was a problem hiding this comment.
Do we need BFD session active/passive mode attributes from FRR for the offload?
|
|
||
| /** Interface index (set to `0` when unavailable). */ | ||
| uint32_t ifindex; | ||
| /** Interface name (empty when unavailable). */ |
There was a problem hiding this comment.
How about multi-hop BFD attribute?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BGP can be configured to use BFD to monitor it's neighbor reachability. when the BFD session becomes DOWN, it indicates that BGP neighbor become not reachable, so BGP can updates the corresponding route quickly based on BFD state, the detection can be much faster than the detection using BGP keep alive approach.
Currently, BGP can use frr/bfdd (a software BFD) to do this.
The proposed design let BGP use hardware offloaded BFD in SONiC, it provide a faster detection, less CPU load, and supports more BGP sessions to use BFD.