snote when an oper sets a chm_hidden mode #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
maybe this should go for oper-only but non-hidden modes too like |
A-UNDERSCORE-D
approved these changes
Feb 10, 2022
dwfreed
requested changes
Apr 14, 2022
| sendto_channel_local_priv(IsServer(source_p) ? fakesource_p : source_p, | ||
| send_flags, priv, chptr, "%s %s", modebuf, parabuf); | ||
| if (priv != NULL && IsClient(source_p)) |
There was a problem hiding this comment.
This doesn't appear to be the test you think it is? priv is only set to non-null when flags is ONLY_OPERS (in which case it is set to auspex:cmodes, which is not the priv used to set the mode), and the only mode changes with mems set to ONLY_OPERS are chm_hidden modes.
| sendto_channel_local_priv(IsServer(source_p) ? fakesource_p : source_p, | ||
| send_flags, priv, chptr, "%s %s", modebuf, parabuf); | ||
| if (priv != NULL && IsClient(source_p)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unideal for code duplication. open to better suggestions
closes #105