Upgrade schema-ddl to 0.25.0-M1 #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istreeter
reviewed
Sep 25, 2024
There was a problem hiding this comment.
Your PR description says
So far, fields starting with a digit wouldn't load properly.
That's not quite true. For other destinations (BigQuery, Hudi etc) we cannot load fields starting with a digit. For Databricks it actually works ok. But we're changing it here so that we can have consistent rules across all destinations. So we don't need to support an extra "if/else" in schema-ddl.
...cala/com/snowplowanalytics/snowplow/rdbloader/transformer/stream/common/parquet/Codecs.scala
Outdated
Show resolved
Hide resolved
|
hey @istreeter , thanks for the heads up regarding the PR description, just updated. I also sent a new commit to remove unnecessary list conversion. |
istreeter
approved these changes
Sep 25, 2024
oguzhanunlu
force-pushed
the
sddl-0.25.0
branch
from
fb76633
to
ee5a3fd
Compare
|
squashed and force pushed, since squash is disabled in github UI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades schema-ddl to 0.25.0-M1, making databricks loader prefix fields with an underscore
_if they start with a number so that we have a consistent behavior across loaders.