Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(memory-leaks): remove elements from the window root #58

Merged

Conversation

BobrImperator
Copy link
Contributor

@BobrImperator BobrImperator commented Jul 10, 2024

  • Adds removing elements explicitly from registries when unobserve is called.
  • Adds removing elements from the default root (window)

In our testing this fixed memory problems related to modifiers that rely on this library.
e.g. ember-in-viewport and ember-scroll-modifiers
When benchmarking memory consumption was lowered from ~210MB to ~45MB.

@BobrImperator BobrImperator changed the title feat(memory-leaks): remove elements from registries when unobserve is called feat(memory-leaks): remove elements from the window root Jul 10, 2024
@mansona mansona mentioned this pull request Jul 15, 2024
@snewcomer snewcomer merged commit d21a428 into snewcomer:master Jul 15, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Jul 15, 2024
@snewcomer snewcomer added the bug Something isn't working label Jul 15, 2024
@BobrImperator BobrImperator deleted the fix-in-viewport-without-dep-upgrades branch July 15, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants