Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to verify that outdated data is still valid #154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tonekk
Copy link

@tonekk tonekk commented Feb 24, 2022

Belongs to this PR in mainserver: smart-village-solutions/smart-village-app-mainserver#249

Screenshot 2022-02-24 at 11 42 39

SVA-252

@codeclimate
Copy link

codeclimate bot commented Feb 24, 2022

Code Climate has analyzed commit ee1f357 and detected 13 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3
Style 10

View more on Code Climate.

Bitte aktualisieren Sie ihre Daten oder bestätigen Sie, dass diese noch aktuell sind:
</div>
<div class="col col-outdated-data">
<%= f.submit "Daten sind noch aktuell", class: "btn btn-primary btn--big" %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because of the submit the form will be sent like hitting the save button, right?
after that, needs_update will be reset and this part disappears?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im Mainserver there ist an "dataprovider.user.touch" on any update, and this :needs_update will disappear if updated_at is junger than 6 month

Comment on lines +22 to +31

.col-outdated-data {
color: #dc3545 !important;
}

.col-outdated-data > input {
background-color: #dc3545 !important;
color: white !important;
width: 100%;
}
Copy link
Member

@donni106 donni106 Jun 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add this to the other custom stylesheets in custom.css to keep the application.css clean with just the requires

Bitte aktualisieren Sie ihre Daten oder bestätigen Sie, dass diese noch aktuell sind:
</div>
<div class="col col-outdated-data">
<%= f.submit "Daten sind noch aktuell", class: "btn btn-primary btn--big" %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im Mainserver there ist an "dataprovider.user.touch" on any update, and this :needs_update will disappear if updated_at is junger than 6 month

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants