Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved rewriteQueue method inside RecordQueue to use the correct lock #2298

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

ozangunalp
Copy link
Collaborator

Because using the correct lock is important...

Regression introduced in #2289

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

Merging #2298 (d2c97b4) into main (5d9b739) will decrease coverage by 0.56%.
Report is 9 commits behind head on main.
The diff coverage is 62.66%.

❗ Current head d2c97b4 differs from pull request most recent head 4788e44. Consider uploading reports for the commit 4788e44 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2298      +/-   ##
============================================
- Coverage     77.90%   77.35%   -0.56%     
- Complexity     3712     3765      +53     
============================================
  Files           302      306       +4     
  Lines         12419    12668     +249     
  Branches       1592     1646      +54     
============================================
+ Hits           9675     9799     +124     
- Misses         2022     2132     +110     
- Partials        722      737      +15     
Files Coverage Δ
...ging/kafka/impl/KafkaRecordStreamSubscription.java 79.66% <100.00%> (-1.59%) ⬇️
...rye/reactive/messaging/kafka/impl/RecordQueue.java 89.47% <100.00%> (+4.28%) ⬆️
...roviders/extension/ReactiveMessagingExtension.java 89.09% <100.00%> (ø)
...e/messaging/providers/i18n/ProviderExceptions.java 100.00% <ø> (ø)
...ye/reactive/messaging/providers/wiring/Wiring.java 93.00% <100.00%> (+0.03%) ⬆️
.../reactive/messaging/rabbitmq/ConnectionHolder.java 76.08% <100.00%> (ø)
...reactive/messaging/rabbitmq/RabbitMQConnector.java 87.61% <ø> (+0.44%) ⬆️
...ive/messaging/rabbitmq/RabbitMQRejectMetadata.java 100.00% <100.00%> (ø)
...ctive/messaging/rabbitmq/fault/RabbitMQAccept.java 100.00% <ø> (ø)
...ive/messaging/rabbitmq/fault/RabbitMQFailStop.java 100.00% <100.00%> (ø)
... and 14 more

... and 14 files with indirect coverage changes

@ozangunalp ozangunalp merged commit 4b91cbb into smallrye:main Sep 27, 2023
5 checks passed
@ozangunalp ozangunalp deleted the rewrite_queue_lock branch September 27, 2023 12:20
@ozangunalp ozangunalp added this to the 4.10.0 milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants