Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate smallrye-reactive-messaging-bom #2242

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Aug 2, 2023

@ozangunalp
Copy link
Collaborator

Nice one! I didn't know we used it in smallrye-common. How does it integrate with deploy?

@gastaldi
Copy link
Contributor Author

gastaldi commented Aug 3, 2023

It generates the artifact during the build and adds to the reactor as a new artifact

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Merging #2242 (b8d69bb) into main (2fa33a6) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head b8d69bb differs from pull request most recent head de41d9b. Consider uploading reports for the commit de41d9b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2242      +/-   ##
============================================
- Coverage     77.88%   77.80%   -0.08%     
- Complexity     3703     3737      +34     
============================================
  Files           301      311      +10     
  Lines         12355    12491     +136     
  Branches       1580     1589       +9     
============================================
+ Hits           9623     9719      +96     
- Misses         2015     2047      +32     
- Partials        717      725       +8     

see 19 files with indirect coverage changes

Copy link
Collaborator

@ozangunalp ozangunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ozangunalp ozangunalp merged commit 413d20d into smallrye:main Aug 3, 2023
2 of 3 checks passed
@gastaldi gastaldi deleted the create_bom branch August 3, 2023 23:49
@ozangunalp ozangunalp added this to the 4.10.0 milestone Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a BOM
3 participants