Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a utility method to coordinate (negative) acknowledgement when multiple messages are created from one #2231

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

cescoffier
Copy link
Contributor

Fix #2191

@cescoffier
Copy link
Contributor Author

@ozangunalp that will be handy to handle @outgoings.
I plan to use it to coordinate acknowledgement when doing broadcast.

* @param messages the chained messages, must not be empty, must not be null, must not contain null
* @return the list of modified messages
*/
public List<Message<?>> with(Message<?>... messages) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may think about wrapping the return into a marker type to integrate with @Outgoings.

If multiple messages are returned we redirect them by order of declaration. If a single message is returned it'd be considered as broadcast.

@ozangunalp ozangunalp merged commit 7856940 into smallrye:main Jul 28, 2023
2 of 3 checks passed
@ozangunalp ozangunalp added this to the 4.9.0 milestone Jul 28, 2023
@cescoffier cescoffier deleted the acknowledgement-coordination branch August 22, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants