Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use provided description for custom scalar if it exists #2176

Merged
merged 1 commit into from
Aug 30, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -252,11 +252,13 @@ private void createGraphQLCustomScalarTypes() {
private void createGraphQLCustomScalarType(CustomScalarType customScalarType) {
String scalarName = customScalarType.getName();

String description = getDescription(customScalarType);

Coercing<?, ?> coercing = getCoercing(customScalarType);

GraphQLScalarType graphQLScalarType = GraphQLScalarType.newScalar()
.name(scalarName)
.description("Scalar for " + scalarName)
.description(description)
.coercing(coercing)
.build();

Expand All @@ -266,6 +268,11 @@ private void createGraphQLCustomScalarType(CustomScalarType customScalarType) {
graphQLScalarType);
}

private static String getDescription(CustomScalarType customScalarType) {
return Optional.ofNullable(customScalarType.getDescription())
.orElse("Scalar for " + customScalarType.getName());
}

private static Coercing<?, ?> getCoercing(CustomScalarType customScalarType) {
CustomScalarPrimitiveType primitiveType = customScalarType.getCustomScalarPrimitiveType();

Expand Down
Loading