Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Throwable class name with wildcard #2013

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

rubik-cube-man
Copy link
Contributor

Fixes an issue where is a configured value ends in a wildcard, the character before the wildcard is ignored.

Previously java.lang* would match with java.land.SomeException.

This also fixes a standalone wildcard (*) throwing an exception as it tries to do a substring of index 0 to -1.

@t1
Copy link
Collaborator

t1 commented Jan 25, 2024

LGTM.

Shouldn't there be tests for this?

@jmartisk jmartisk merged commit 2cd6255 into smallrye:main Jan 25, 2024
5 checks passed
@jmartisk
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants