Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching createGraphQLEnumTypes and createGraphQLDirectiveTypes to allow EnumTypes directive arguments #1979

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

mskacelik
Copy link
Contributor

/cc @jmartisk
fixes: #1978

Possible two edge case problems:

  • if the EnumType has another directive whose arguments have a different EnumType that has yet to be added to the enumMap.
  • Circular dependency: for example, EnumType has a directive whose argument is the same EnumType

For the second case, I think it's not doable even using the raw java-graphql API since the GraphQLEnumType would need a reference to itself in its definition.

Copy link
Member

@jmartisk jmartisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jmartisk jmartisk merged commit 2871a2a into smallrye:main Nov 24, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enum type is not supported in directive arguments
2 participants