Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added fix for non-necessary json transformation for ObjectId argument value #1951

Merged
merged 1 commit into from
Nov 6, 2023
Merged

added fix for non-necessary json transformation for ObjectId argument value #1951

merged 1 commit into from
Nov 6, 2023

Conversation

mskacelik
Copy link
Contributor

fixes: #1950
/cc @jmartisk

jmartisk
jmartisk requested changes Nov 6, 2023
View reviewed changes
Copy link
Member

@jmartisk jmartisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I've just asked to add a little more explanation why we're doing this, because it's an ugly hack...

...mentation/src/main/java/io/smallrye/graphql/execution/datafetcher/helper/ArgumentHelper.java Outdated Show resolved Hide resolved
@jmartisk jmartisk merged commit f861a69 into smallrye:main Nov 6, 2023
5 checks passed
@mskacelik mskacelik deleted the issue-objectId branch November 6, 2023 21:57
@chokme
Copy link

chokme commented Nov 7, 2023

Thanks for this fix :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartisk jmartisk jmartisk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues in handling Mongo ObjectId
3 participants
@mskacelik @chokme @jmartisk