Giving cavity characterization more time before throwing an error #137
Conversation
…e last one took a minute and a half and erroneously marked as failed)
| raise utils.CavityQLoadedCalibrationError( | ||
| f"{self} characterization did not start" | ||
| f"{self} characterization took longer than 5 minutes to run" |
There was a problem hiding this comment.
waiting for 5min without any feedback on progress makes me guess that people will start saying 'the GUI is frozen'. Maybe 2 or 3minutes? Or can we think of any way to convey that things are actually happening?
There was a problem hiding this comment.
Well the thing is that right now it's just waiting indefinitely (not even just 5 minutes but however long it takes for characterization to run) in the while self.characterization_running section. This chunk is just to check that we for sure had a successful characterization within the last 5 minutes, in case it actually didn't start
There was a problem hiding this comment.
Oh right. Maybe the better wording then would be 'no valid characterization within the last 5 min'?
The last global setup led to characterizations that took ~1.5 minutes and erroneously marked them as failed. Also adding missing abort check