Allowing for bypassing detune check during motor move #133
Conversation
| :return: | ||
| """ | ||
|
|
||
| self.check_abort() | ||
| maxSteps = abs(maxSteps) | ||
|
|
||
| if changeLimits: | ||
| # on the off chance that someone tries to write a negative maximum |
There was a problem hiding this comment.
Is a negative no longer a problem?
There was a problem hiding this comment.
This just immediately turns max steps into a positive number regardless of what the user requested
There was a problem hiding this comment.
So this is the max steps possible for all cavities, which is some default in utils.DEFAULT_STEPPER_MAX_STEPS? Is the default sometimes neg?
There was a problem hiding this comment.
Lisa clarified, it's the maxSteps for one tuner movement.
|
|
||
| def issueMoveCommand(self, numSteps): | ||
| def issueMoveCommand(self, numSteps: int, check_detune: bool = True): | ||
| # this is necessary because the tuners for the HLs move the other direction | ||
| if self.cavity.cryomodule.is_harmonic_linearizer: | ||
| numSteps *= -1 |
There was a problem hiding this comment.
Maybe this is the answer to my q above. You check here now?
There was a problem hiding this comment.
No, this is numSteps, which is slightly different (I should probably figure out a way to rewrite this lol). It's the number of steps requested by the user vs the maximum number of steps allowed by the stepper
| :return: | ||
| """ | ||
|
|
||
| self.check_abort() | ||
| maxSteps = abs(maxSteps) | ||
|
|
||
| if changeLimits: | ||
| # on the off chance that someone tries to write a negative maximum |
There was a problem hiding this comment.
Lisa clarified, it's the maxSteps for one tuner movement.
Also addressing issue #132