Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #107

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Cleanup #107

merged 5 commits into from
Nov 9, 2023

Conversation

nneveu
Copy link
Member

@nneveu nneveu commented Nov 9, 2023

Some files/directories cleaned up:

  • Moved matlab image file from examples to tests/datasets/images/matlab
  • Old sol_calc file moved to new beam/transverse folder
  • init files removed as needed
  • Old grab images example file removed

@nneveu
Copy link
Member Author

nneveu commented Nov 9, 2023

Moved sol_calc test file to try to pass checks

@nneveu nneveu self-assigned this Nov 9, 2023
MattKing06
MattKing06 approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@MattKing06 MattKing06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor code changes that are just adjusting imports to reorganization so that's good.
Always good to delete some old files too!

@nneveu nneveu merged commit 20ed87f into slaclab:main Nov 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattKing06 MattKing06 MattKing06 approved these changes

@lisazacarias lisazacarias Awaiting requested review from lisazacarias

Assignees

@nneveu nneveu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nneveu @MattKing06