Automatic yaml generation for magnets and screens #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng. Can extract by area
…automatic_yaml_generation
…tKing06/lcls-tools into 92_automatic_yaml_generation
…tKing06/lcls-tools into 92_automatic_yaml_generation
…tKing06/lcls-tools into 92_automatic_yaml_generation
…tKing06/lcls-tools into 92_automatic_yaml_generation
…tKing06/lcls-tools into 92_automatic_yaml_generation
…tKing06/lcls-tools into 92_automatic_yaml_generation
…tKing06/lcls-tools into 92_automatic_yaml_generation
…tKing06/lcls-tools into 92_automatic_yaml_generation
added 2 commits
October 30, 2023 21:36
…tKing06/lcls-tools into 92_automatic_yaml_generation
nneveu
requested changes
Oct 31, 2023
| import meme.names | ||
| import numpy as np | ||
|
|
||
|
|
| ] | ||
| return areas | ||
|
|
||
| def get_areas(self) -> list: |
| ] | ||
| return beampaths | ||
|
|
||
| def get_beam_paths(self) -> list: |
| self, element, pv_information: Optional[Dict[str, str]] = {} | ||
| ): | ||
| sum_l_meters = float(element["SumL (m)"]) if element["SumL (m)"] else -1.0 | ||
| return { |
There was a problem hiding this comment.
change -1.0 to none or something else?
| }, | ||
| } | ||
|
|
||
| def _construct_pv_list_from_control_system_name( |
| ) | ||
| except RuntimeError as rte: | ||
| print(rte) | ||
| yaml_magnets.update({magnet["Element"]: {}}) |
There was a problem hiding this comment.
set value to function in next line instead?
| machine_areas = [area] | ||
| else: | ||
| machine_areas = area | ||
| for _area in machine_areas: |
There was a problem hiding this comment.
is this loop the same as magnet loop? combine into utility function?
| class YAMLWriter: | ||
| def __init__(self): | ||
| self.generator = YAMLGenerator() | ||
| self.machine_areas = self.generator.areas |
There was a problem hiding this comment.
maybe just use 'areas' instead of 'machine_area'
| def _is_area(self, area: str): | ||
| return area in self._machine_areas | ||
|
|
||
| def _constuct_yaml_contents(self, area: str) -> dict: |
| return None | ||
|
|
||
| def write_yaml_file(self, area: Optional[str] = "GUNB") -> None: | ||
| if area not in self.machine_areas: |
There was a problem hiding this comment.
change machine_areas to generator.areas
nneveu
approved these changes
Oct 31, 2023
Derikka
pushed a commit
to Derikka/lcls-tools
that referenced
this pull request
Mar 17, 2024
* magnets and screen conversion from csv to dictionary structures working. Can extract by area * add functionality for extracting multiple areas at once * add PVs to yaml magnets extraction * removing unneeded file * working on adding image pvs to yaml files * working on image device code * flake8 and black formatting * make construction function self, add error handling for MEME timeout * formatting * make area a list in screens * add pv_info to screen construction * restrict wildcard search in meme * add areas and beampaths as members of YAMLGenerator * only construct yaml data if you find a Control System Name * initial class for writing yaml files by area * colon? * unindent loop * return when no devices found for that area * only return info if it exists, otherwise return None * add extra PVs for screen searching * write yaml when you have either magnet or screen contents * remove walrus operator for 3.6 :( * make sum_l_meters a 2 sig fig fp number, make beampaths a list * remove tuple error * force float casting * adding first version of yaml files for magnets and screens * reformat * refactoring extract_devices function from extract_magnets and extract_screens * remove member variable for machine_areas, access only via generator * tidy up with comments * removing files without PV information --------- Co-authored-by: Neveu <nneveu@pc101046.slac.stanford.edu> Co-authored-by: Neveu <nneveu@stanford.edu> Co-authored-by: matt <matt@SLACMachine.myguest.virtualbox.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Created a generate class to convert csv data into yaml files via classes.
Also, write.py will create yaml files for every area (from lcls_elements.csv) and in each file there will be screen and magnet data injected.
The structure of the file should be as such:
The .yaml files now in
common/devices/yamlhave been created using write.py