Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new abstractions package #15

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

corstian
Copy link
Member

Most important changes as of now;

  1. BodyBuilder on the MailBase is public get only instead of protected internal.
  2. Skyhop.Mail.Abstractions package contains the MailBase class, which is still in the Skyhop.Mail namespace to prevent breaking too much things.
  3. Two packages are now generated instead of one.

Most important changes as of now;
1. BodyBuilder on the MailBase is public get only instead of protected internal.
2. Skyhop.Mail.Abstractions package contains the MailBase class, which is still in the Skyhop.Mail namespace to prevent breaking too much things.
3. Two packages are now generated instead of one.
Skyhop.Mail.sln Outdated Show resolved Hide resolved
src/Skyhop.Mail/MailDispatcher.cs Show resolved Hide resolved
@synercoder
Copy link
Collaborator

I added 2 conditional references in the base csproj

@corstian
Copy link
Member Author

corstian commented Feb 17, 2021

Thanks, overlooked that part!

Ps. while I'm at it, let me check whether I can configure actions to automatically push to NuGet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants