Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move scheduling logic to the mlpop lua command #14

Open
wants to merge 6 commits into
base: skroutz
Choose a base branch
from
Open

Move scheduling logic to the mlpop lua command #14

wants to merge 6 commits into from

Commits on Feb 19, 2021

  1. Move scheduling logic to the mlpop lua command 

    Resque finds jobs by iterating on a list of queues, for each queue it
tries to lpop a job until successful.

This patch moves that logic to the server by implementing mlpop,
that approach reduces the required round-trips especially for workers
watching a large set of queues.

The API is not altered, we keep the same signature while accepting
variadic arguments.
    @ctrochalakis
    ctrochalakis committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    b3c7cd9 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Lazarus Lazaridis <9477868+iridakos@users.noreply.github.com>
    @ctrochalakis @iridakos
    ctrochalakis and iridakos committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    f7b6c4e View commit details
    Browse the repository at this point in the history

  3. Update lib/resque.rb

    @ctrochalakis
    ctrochalakis committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    df656f5 View commit details
    Browse the repository at this point in the history

  4. Update lib/resque/data_store.rb

    @ctrochalakis
    ctrochalakis committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    f8aea2b View commit details
    Browse the repository at this point in the history

  5. fixup! Move scheduling logic to the mlpop lua command

    @ctrochalakis
    ctrochalakis committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    69e3967 View commit details
    Browse the repository at this point in the history

  6. fixup! Move scheduling logic to the mlpop lua command

    @ctrochalakis
    ctrochalakis committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    142f8c0 View commit details
    Browse the repository at this point in the history