Configurable hrtb_*, Float param support #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
April 22, 2016 11:29
`python setup.py` install for installing from source or `python setup.py` develop for hacking.
so that we can configure heartbeat intervals and retransmits at run time.
Rtp_proxy_client(). Requires a rtpproxy socket to run. Would be nice to mock that socket instead.
Remove redundant '\' symbols from between ()'s Raise exceptions using the new style.
Added `F` for Float support to MyConfigParser. Moved tests from __main__ target into its own untitest. Set the hrtb_* params as properties, instead of passing them in via the global_config dict.
| 'xmpp_b2bua_id': ('I', 'ID passed to the XMPP socket server'), | ||
| 'hrtb_retr_ival': ('F', 'Heartbeat retransmit value for rtpproxy client'), | ||
| 'hrtb_ival': ('F', 'Heartbeat interval for rpproxy client')} | ||
|
|
added 2 commits
April 22, 2016 18:09
This reverts commit e2c090a.
line breaks before a class declaration. Kill one superfluous new line.
sippy/Rtp_proxy_client.py
Outdated
| @@ -88,6 +88,7 @@ def __init__(self, global_config, *address, **kwargs): | |||
| if kwargs.has_key('no_version_check'): | |||
| no_version_check = kwargs['no_version_check'] | |||
| del kwargs['no_version_check'] | |||
|
|
|||
There was a problem hiding this comment.
Please remove the whole patch (Rtp_proxy_client.py).
jevonearth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --hrtb_ival and --hrtb_retr_ival command line arguments can now set the heartbeat intervals used by the rtpproxy client in b2bua.
Print a friendly message and sys.exit() when log file can't be open
Add float datatype to MyConfigParser.
Add tests to cover MyConfigParser.