Skip to content

Commit

Permalink
Don't include own IP into call-id: it serves no practical purpose
Browse files Browse the repository at this point in the history
and can lead to the information leak.
  • Loading branch information
sobomax committed Sep 25, 2024
1 parent 207bf8e commit a191df4
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions sippy/SipCallId.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,15 +52,14 @@ def __init__(self, body = None):
SipGenericHF.__init__(self, body)
self.parsed = True
if body is None:
salt = str((random() * 1000000000) + time())
self.body = md5(salt.encode()).hexdigest() + '@' + str(SipConf.my_address)
self.genCallId()

def __add__(self, other):
return SipCallId(self.body + str(other))

def genCallId(self):
salt = str((random() * 1000000000) + time())
self.body = md5(salt.encode()).hexdigest() + '@' + str(SipConf.my_address)
self.body = md5(salt.encode()).hexdigest()

def getCanName(self, name, compact = False):
if compact:
Expand Down

0 comments on commit a191df4

Please sign in to comment.