Feat/add methods to root of numbers #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dovchik
requested review from
650elx,
krogers0607,
asein-sinch and
JPPortier
as code owners
asein-sinch
reviewed
Aug 1, 2024
asein-sinch
reviewed
Aug 19, 2024
| @@ -91,7 +101,9 @@ public ActiveNumbers(string projectId, Uri baseAddress, | |||
| _http = http; | |||
| } | |||
|
|
|||
| public Task<ListActiveNumbersResponse> List(ListActiveNumbersRequest request, CancellationToken cancellationToken = default) | |||
|
|
|||
| public Task<ListActiveNumbersResponse> List(ListActiveNumbersRequest request, | |||
There was a problem hiding this comment.
I'm curious about why the formatting changed as there is no configuration change in this PR. Is it linked to the IDE? I just want to make sure this is intentional and won't be reverted by an auto-formatting in another PR.
There was a problem hiding this comment.
Auto formatted by IDE agnostic dotnet format
| @@ -25,6 +35,42 @@ public interface ISinchNumbers | |||
| /// release numbers from projects, or list all numbers assigned to a project. | |||
| /// </summary> | |||
| public ISinchNumbersActive Active { get; } | |||
There was a problem hiding this comment.
You may also mark this as obsolete before changing the visibility in the next major
asein-sinch
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add available and active numbers to root of Numbers client.
Leaving added methods as obsolete in own tag for backward compatibility.