Skip to content

Commit

Permalink
fix: typo in msisdn
Browse files Browse the repository at this point in the history
  • Loading branch information
Dovchik committed Sep 6, 2023
1 parent a84eec9 commit 5b5dc87
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions src/Sinch/SMS/DeliveryReports/DeliveryReports.cs
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ public interface IDeliveryReports
/// A recipient delivery report contains the message status for a single recipient phone number.
/// </summary>
/// <param name="batchId">The batch ID you received from sending a message.</param>
/// <param name="recipientMisdn">Phone number for which you to want to search.</param>
/// <param name="recipientMsisdn">Phone number for which you to want to search.</param>
/// <param name="cancellationToken"></param>
/// <returns></returns>
Task<DeliveryReport> GetForNumber(string batchId, string recipientMisdn,
Task<DeliveryReport> GetForNumber(string batchId, string recipientMsisdn,
CancellationToken cancellationToken = default);

/// <summary>
Expand All @@ -52,7 +52,8 @@ Task<DeliveryReport> GetForNumber(string batchId, string recipientMisdn,
IAsyncEnumerable<DeliveryReport> ListAuto(List.Request request, CancellationToken cancellationToken = default);
}

public class DeliveryReports : IDeliveryReports
/// <inheritdoc />
internal class DeliveryReports : IDeliveryReports
{
private readonly Uri _baseAddress;
private readonly IHttp _http;
Expand All @@ -76,13 +77,13 @@ public Task<Response> Get(Request request, CancellationToken cancellationToken =
return _http.Send<Request, Response>(uri, HttpMethod.Get, null, cancellationToken)!;
}

public Task<DeliveryReport> GetForNumber(string batchId, string recipientMisdn,
public Task<DeliveryReport> GetForNumber(string batchId, string recipientMsisdn,
CancellationToken cancellationToken = default)
{
var uri = new Uri(_baseAddress,
$"xms/v1/{_projectId}/batches/{batchId}/delivery_report/{recipientMisdn}");
$"xms/v1/{_projectId}/batches/{batchId}/delivery_report/{recipientMsisdn}");

_logger?.LogDebug("Fetching delivery report for a {number} of a {batchId}", recipientMisdn, batchId);
_logger?.LogDebug("Fetching delivery report for a {number} of a {batchId}", recipientMsisdn, batchId);

return _http.Send<object, DeliveryReport>(uri, HttpMethod.Get, null, cancellationToken)!;
}
Expand Down

0 comments on commit 5b5dc87

Please sign in to comment.