Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: Required h5py>=3 #300

Merged
merged 9 commits into from
Jul 3, 2024
Merged

Dependencies: Required h5py>=3 #300

merged 9 commits into from
Jul 3, 2024

Conversation

t20100
Copy link
Member

@t20100 t20100 commented Apr 5, 2024

Merge PR #298 first!

This PR update the minimum version of h5py to v3.
This allows to clean-up some of the compatibility code.

@t20100 t20100 added this to the 5.0.0 milestone Apr 5, 2024
@t20100 t20100 requested a review from kif April 5, 2024 15:26
@t20100 t20100 force-pushed the require-h5py-3 branch 2 times, most recently from 1b0ff9d to 79f05ed Compare April 5, 2024 15:50
@t20100 t20100 marked this pull request as draft April 5, 2024 15:53
@t20100 t20100 force-pushed the require-h5py-3 branch 3 times, most recently from df082d2 to a684764 Compare April 15, 2024 13:27
@t20100 t20100 marked this pull request as ready for review April 15, 2024 13:30
@t20100
Copy link
Member Author

t20100 commented Apr 15, 2024

Ready for review!

@t20100 t20100 marked this pull request as draft June 7, 2024 11:53
@t20100 t20100 marked this pull request as ready for review July 3, 2024 09:51
@t20100
Copy link
Member Author

t20100 commented Jul 3, 2024

Rebased, ready for review

Copy link
Member

@kif kif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kif kif merged commit 2c3a3b4 into silx-kit:main Jul 3, 2024
7 checks passed
@t20100 t20100 deleted the require-h5py-3 branch July 3, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants