Proposed fix for issue #25 #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, obviously no one else is going to look into this so can do :) Do you know the reason why Checkboxs aren't in the $data array? Ideally custom stuff like populateFromPostData() should be as nice as $this->update($data) and let the ORM do it's thing. My worry with this patch is a checkbox which is set to true, not in the cms (or hidden for some reason) is now going to default to false causing more confusing issues. |
|
$data is derived in this case straight from $_REQUEST https://github.com/silverstripe/silverstripe-widgets/blob/master/code/form/WidgetAreaEditor.php#L123, which if a checkbox is not checked it simply does not appear in the request data nore $_POST. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been running into checkboxes not saving with a project (issue #25), this is the best way I can think of to resolve it short of a major re-think of how the WidgetEditorArea works. The only other thing I can think of is to iterate the fields rather than the data submitted and do the work-around there.