Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Only query primary DB #114

Open
wants to merge 1 commit into
base: 4
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Model/HybridSessionDataObject.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,10 @@ class HybridSessionDataObject extends DataObject
];

private static $table_name = 'HybridSessionDataObject';

/**
* Ensure there is no risk of reading from an unsynced database replica so
* that session data is always up to date.
*/
private static bool $must_use_primary_db = true;
GuySartorelli marked this conversation as resolved.
Show resolved Hide resolved
}
2 changes: 1 addition & 1 deletion src/Store/DatabaseStore.php
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public function read(string $session_id): string|false
$this->getNow()
);

$result = DB::query($query);
$result = DB::withPrimary(fn() => DB::query($query));

if ($result && $result->numRecords()) {
$data = $result->record();
Expand Down
Loading