MNT Remove TODO comments #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabina-talipova
commented
Oct 13, 2023
| @@ -22,7 +22,6 @@ class Handler | |||
| * @var array | |||
| * | |||
| * @internal Experimental config: | |||
| * @todo Move this to a per-schema configuration and refer to this schema from the current endpoint | |||
There was a problem hiding this comment.
Open ticket: #555
sabina-talipova
commented
Oct 13, 2023
| @@ -112,7 +112,6 @@ protected function getCachedResponse(string $key): ?array | |||
| // On cache success validate against cached classes | |||
| foreach ($cached['classes'] as $class) { | |||
| // Note: Could combine these clases into a UNION to cut down on extravagant queries | |||
| // Todo: We can get last-deleted/modified as well for versioned records | |||
There was a problem hiding this comment.
Open ticket: #554
sabina-talipova
commented
Oct 13, 2023
GuySartorelli
requested changes
Oct 24, 2023
sabina-talipova
force-pushed
the
pulls/5.1/remove-todo
branch
from
678aaeb
to
d064b8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue