API Standardise extension hooks (#202)

silverstripe · Aug 27, 2024 · 3146434 · 3146434
1 parent 791d493
commit 3146434
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/code/FrameworkTestRole.php b/code/FrameworkTestRole.php
@@ -24,7 +24,7 @@ protected function updateCMSFields(FieldList $fields)
         );
     }
 
-    public function requireDefaultRecords()
+    protected function onRequireDefaultRecords()
     {
         $hasTestMembers = Member::get()->find('Email', 'hayley@test.com');
         if (!$hasTestMembers) {

diff --git a/code/TestDataObjectExtension.php b/code/TestDataObjectExtension.php
@@ -24,22 +24,22 @@ public function providePermissions()
         ];
     }
 
-    public function canView($member = null) 
+    protected function canView($member = null)
     {
         return Permission::check('TEST_DATAOBJECT_EDIT', 'any', $member);
     }
 
-    public function canEdit($member = null) 
+    protected function canEdit($member = null)
     {
         return Permission::check('TEST_DATAOBJECT_EDIT', 'any', $member);
     }
 
-    public function canDelete($member = null) 
+    protected function canDelete($member = null)
     {
         return Permission::check('TEST_DATAOBJECT_EDIT', 'any', $member);
     }
 
-    public function canCreate($member = null, $context = []) 
+    protected function canCreate($member = null, $context = [])
     {
         return Permission::check('TEST_DATAOBJECT_EDIT', 'any', $member);
     }

diff --git a/code/elemental/ElementContentExtension.php b/code/elemental/ElementContentExtension.php
@@ -28,7 +28,7 @@ class ElementContentExtension extends Extension
         'MyFile' => File::class,
     ];
 
-    public function validate(ValidationResult $result)
+    protected function updatevalidate(ValidationResult $result)
     {
         if ($this->owner->Title == 'x') {
             $result->addFieldError('Title', 'Title cannot be x');

diff --git a/code/fields/NestedGridField/SecurityAdminExtension.php b/code/fields/NestedGridField/SecurityAdminExtension.php
@@ -8,7 +8,7 @@
 
 class SecurityAdminExtension extends Extension
 {
-    public function updateGridFieldConfig($config)
+    protected function updateGridFieldConfig($config)
     {
         if ($this->owner->getModelClass() === Group::class) {
           $config->addComponent(GridFieldNestedForm::create()->setRelationName('Members'));