DEP Use PHPUnit 11 #11361
Merged
DEP Use PHPUnit 11 #11361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
emteknetnz
force-pushed
the
pulls/6/phpunit11
branch
3 times, most recently
from
aff6913
to
0017f81
Compare
emteknetnz
force-pushed
the
pulls/6/phpunit11
branch
from
0017f81
to
1835859
Compare
emteknetnz
commented
Sep 9, 2024
emteknetnz
commented
Sep 9, 2024
emteknetnz
commented
Sep 9, 2024
emteknetnz
commented
Sep 9, 2024
emteknetnz
commented
Sep 9, 2024
emteknetnz
commented
Sep 9, 2024
emteknetnz
force-pushed
the
pulls/6/phpunit11
branch
2 times, most recently
from
2a5cb16
to
04ba00c
Compare
emteknetnz
commented
Sep 9, 2024
| @@ -134,7 +134,6 @@ protected function withBaseFolder($folder, $callback) | |||
|
|
|||
| /** | |||
| * Submit a get request | |||
| * @uses Director::test() | |||
There was a problem hiding this comment.
As far as I can tell @uses was for code-coverage
I'm not sure what the replacement for @uses is sebastianbergmann/phpunit#4502
This was already not-recommended as @uses ClassName::methodName (not recommended because too fine-grained)
We're not doing any sort of code-coverage at this point
I did try using #[UsesMethod('Director', 'test')] however it will complain Attribute "PHPUnit\Framework\Attributes\UsesMethod" cannot target method (allowed targets: class)
I've elected to just remove these instead
emteknetnz
force-pushed
the
pulls/6/phpunit11
branch
from
04ba00c
to
c875b45
Compare
emteknetnz
commented
Sep 9, 2024
emteknetnz
force-pushed
the
pulls/6/phpunit11
branch
4 times, most recently
from
5f8c960
to
eae82cf
Compare
emteknetnz
commented
Sep 10, 2024
emteknetnz
force-pushed
the
pulls/6/phpunit11
branch
3 times, most recently
from
7101d11
to
9238c84
Compare
emteknetnz
commented
Sep 11, 2024
emteknetnz
force-pushed
the
pulls/6/phpunit11
branch
from
9238c84
to
68c5db9
Compare
emteknetnz
commented
Sep 11, 2024
emteknetnz
force-pushed
the
pulls/6/phpunit11
branch
from
68c5db9
to
67c7010
Compare
emteknetnz
force-pushed
the
pulls/6/phpunit11
branch
6 times, most recently
from
9878ee6
to
8bdeb50
Compare
GuySartorelli
requested changes
Sep 16, 2024
emteknetnz
force-pushed
the
pulls/6/phpunit11
branch
2 times, most recently
from
b1592ce
to
540fcd7
Compare
emteknetnz
commented
Sep 16, 2024
GuySartorelli
approved these changes
Sep 17, 2024
emteknetnz
force-pushed
the
pulls/6/phpunit11
branch
2 times, most recently
from
a25843e
to
e2010cf
Compare
emteknetnz
force-pushed
the
pulls/6/phpunit11
branch
from
e2010cf
to
9a92488
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#305
PHPUnit 10 removed the ability to unit test Error's, Deprecation's, Warning's and Strict's, so I've set a custom error handler to convert all those to unit test specific exceptions instead
I've also updated a couple of dependencies which PHPUnit 11 requires: