Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shift private static variables from yaml file to classes #828

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Shift private static variables from yaml file to classes #828

merged 1 commit into from
Jun 25, 2024

Conversation

AntonyThorpe
Copy link
Contributor

Some variables are declared in config.yml. Shift them into the classes so that they can be found :). Thanks.

@AntonyThorpe
Shift private static variables from yaml file to classes
d1df253 
Remove private static variables from config.yml & add them to ProductImageExtension & MemberExtension classes
Add missing private static disable_security_token to ShoppingCartController class
Remove OrderProcessor.bcc_receipt_to_admin from config.yml (it is not used)
@AntonyThorpe
Copy link
Contributor Author

Thanks for approving my PR @wilr. What happens next please?

@wilr wilr merged commit 19e2e29 into silvershop:main Jun 25, 2024
9 checks passed
@AntonyThorpe AntonyThorpe deleted the StaticVariables branch June 25, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilr wilr wilr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntonyThorpe @wilr