Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silverstripe 5 support #789

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Silverstripe 5 support #789

merged 2 commits into from
Sep 27, 2023

Conversation

elliot-sawyer
Copy link

@elliot-sawyer elliot-sawyer commented Aug 17, 2023

I've started the work to upgrade this module to Silverstripe 5 and have managed it with very few changes required.

It's not mergeable as-is unless you add my forks to the repositories key to your parent project (composer seems to ignore the upstream ones). The pull requests need to be accepted, so I can update this pull request to use a stable tag, or a specific commit until it is marked stable

    "repositories": {
        "silvershop/core": {
            "type": "vcs",
            "url": "git@github.com:elliot-sawyer/silvershop-core.git"
        },
        "silvershop/silverstripe-listsorter": {
            "type": "vcs",
            "url": "git@github.com:elliot-sawyer/silverstripe-listsorter.git"
        },
        "silvershop/silverstripe-sqlquerylist": {
            "type": "vcs",
            "url": "git@github.com:elliot-sawyer/silverstripe-sqlquerylist.git"
        }
    },

The only coding change required was on sqlquerylist, which changed the method signature on limit to support type hinting and return types. There may be more to be checked inside the tests, but I haven't gone into those.

Once those upstream dependencies are merged in, this should be safe to merge

@elliot-sawyer
Copy link
Author

elliot-sawyer commented Aug 19, 2023

Unrelated to the above, when I tried to install silvershop/silverstripe-hasonefield it results in a 500 error when adding it to a DataObject's CMS fields (I think it was Order). That was in a DataExtension so quite possible I was doing something wrong

@wilr wilr merged commit 52afb17 into silvershop:main Sep 27, 2023
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants