Minor updates as highlighted by Scrutinizer #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- OrderTotalCalculator.php: added missing public function declarations - Used setField to apply values to fields in OrderProcessor.php, OrderActionsForm.php, Order.php & OrderStatusLog.php - OrderProcessor.php: `Company` variable exists on the Address class (not Order) Docs - ShoppingCartController.php: added `string` to return type - Product.php: added `false` as a possible return type to documentation of addLink, removeLink and removeallLink functions - Variation.php: added `false` as a possible return type to the Link function - CheckoutComponentConfig.php: corrected docs for the getComponentByType function Removed unused variables - $page & $termsPage in PopulateShopTask.php - $success in VariationForm.php - $response in OrderStatusLogTest.php - $filterperiod in ProductReport.php - $record variable in imageByFilename & setParent functions in ProductBulkLoader.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR following a review of the Scrutinizer reports. Thanks.