fix(iframe-fixes): fix bug where removeNode fails due to not being pa…

…tched like appendNode attempt #2 (#20) Fixes #18
silbinarywolf · Nov 28, 2019 · df74f0e · df74f0e
1 parent 348f275
commit df74f0e
Show file tree

Hide file tree

Showing 3 changed files with 3,893 additions and 3,468 deletions.
diff --git a/lib/iframe-fixes.ts b/lib/iframe-fixes.ts
@@ -47,7 +47,7 @@ function overrideSpecIFrameToApplyToAppIFrame(): void {
   // end up causing "The node to be removed is not a child of this node." errors.
   {
     const documentRemoveChild = function <T extends Node>(this: T): T {
-      return appDocument.appendChild.apply(appDocument, arguments as any) as T;
+      return appDocument.removeChild.apply(appDocument, arguments as any) as T;
     };
     if (specDocument.removeChild !== documentRemoveChild) {
       specDocument.removeChild = documentRemoveChild;
@@ -69,7 +69,7 @@ function overrideSpecIFrameToApplyToAppIFrame(): void {
   // end up causing "The node to be removed is not a child of this node." errors.
   {
     const bodyRemoveChild = function <T extends Node>(this: T): T {
-      return appDocument.appendChild.apply(appDocument, arguments as any) as T;
+      return appDocument.body.removeChild.apply(appDocument, arguments as any) as T;
     };
     if (specDocument.body.removeChild !== bodyRemoveChild) {
       specDocument.body.removeChild = bodyRemoveChild;