chore: drop activateLogicalVolumes sequencer step

Drop `activateLogicalVolumes` sequencer step. LVM package already ships proper udev rules to handle this. ```text ❯ tree lvm2/usr/lib/udev/rules.d/ lvm2/usr/lib/udev/rules.d/ ├── 10-dm.rules ├── 11-dm-lvm.rules ├── 13-dm-disk.rules ├── 69-dm-lvm.rules └── 95-dm-notify.rules 1 directory, 5 files ``` Fixes: #9300 Signed-off-by: Noel Georgi <git@frezbo.dev>
siderolabs · Sep 11, 2024 · e17fafa · e17fafa
1 parent a294b36
commit e17fafa
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 15 deletions.
diff --git a/internal/app/machined/pkg/runtime/v1alpha1/v1alpha1_sequencer.go b/internal/app/machined/pkg/runtime/v1alpha1/v1alpha1_sequencer.go
@@ -271,10 +271,6 @@ func (*Sequencer) Boot(r runtime.Runtime) []runtime.Phase {
 	).Append(
 		"userSetup",
 		pauseOnFailure(WriteUserFiles, constants.FailurePauseTimeout),
-	).AppendWhen(
-		r.State().Platform().Mode() != runtime.ModeContainer,
-		"lvm",
-		ActivateLogicalVolumes,
 	).Append(
 		"extendPCRStartAll",
 		ExtendPCRStartAll,

diff --git a/internal/app/machined/pkg/runtime/v1alpha1/v1alpha1_sequencer_tasks.go b/internal/app/machined/pkg/runtime/v1alpha1/v1alpha1_sequencer_tasks.go
@@ -2011,17 +2011,6 @@ func Install(runtime.Sequence, any) (runtime.TaskExecutionFunc, string) {
 	}, "install"
 }
 
-// ActivateLogicalVolumes represents the task for activating logical volumes.
-func ActivateLogicalVolumes(runtime.Sequence, any) (runtime.TaskExecutionFunc, string) {
-	return func(ctx context.Context, logger *log.Logger, r runtime.Runtime) (err error) {
-		if _, err = cmd.Run("/sbin/lvm", "vgchange", "-ay"); err != nil {
-			return fmt.Errorf("failed to activate logical volumes: %w", err)
-		}
-
-		return nil
-	}, "activateLogicalVolumes"
-}
-
 // KexecPrepare loads next boot kernel via kexec_file_load.
 //
 //nolint:gocyclo