Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve function exports #29

Merged
merged 3 commits into from
Mar 4, 2024
Merged

refactor: Improve function exports #29

merged 3 commits into from
Mar 4, 2024

Conversation

zoey-kaiser
Copy link
Member

@zoey-kaiser zoey-kaiser commented Mar 4, 2024

Closes N/A

Exports all PDF components directly instead of injecting them into the PDF object. This reduces the total bundle size and allows code splitting to only import the needed components instead of requiring that the module injects all the components on PDF initialization.

Improves inline documentation for all functions and removes dirty function types. These are functions, where the export type is not properly defined, leading to TS needing to infer the type, instead of it being properly set.

Checklist:

  • issue number linked above after pound (#)
    • replace "Closes " with "Contributes to" or other if this PR does not close the issue
  • manually checked my feature / checking not applicable
  • wrote tests / testing not applicable
  • attached screenshots / screenshot not applicable

@zoey-kaiser zoey-kaiser changed the title feat: Improve function exports refactor: Improve function exports Mar 4, 2024
@zoey-kaiser zoey-kaiser merged commit 0ceee35 into main Mar 4, 2024
1 check passed
@zoey-kaiser zoey-kaiser deleted the improve-exports branch March 4, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant