Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error #282

Closed
wants to merge 9 commits into from
Closed

Fix compile error #282

wants to merge 9 commits into from

Conversation

SkyfallWasTaken
Copy link

Before this commit, Poise compilation would fail with this error:

error[E0432]: unresolved import `crate::serenity`
  --> src/builtins/mod.rs:20:13
   |
20 | use crate::{serenity::CreateAllowedMentions, serenity_prelude as serenity, CreateReply};
   |             ^^^^^^^^
   |             |
   |             unresolved import
   |             help: a similar path exists: `crate::prefix_argument::key_value_args::serenity`

For more information about this error, try `rustc --explain E0432`.
error: could not compile `poise` (lib) due to 1 previous error

Now, compilation succeeds successfully.

GnomedDev and others added 8 commits June 7, 2024 19:10
* Use Http instead of CacheHttp

* Fix examples compiling

* Update MSRV lockfile

---------

Co-authored-by: GnomedDev <david2005thomas@gmail.com>
Before this commit, Poise compilation would fail with this error:

```
error[E0432]: unresolved import `crate::serenity`
  --> src/builtins/mod.rs:20:13
   |
20 | use crate::{serenity::CreateAllowedMentions, serenity_prelude as serenity, CreateReply};
   |             ^^^^^^^^
   |             |
   |             unresolved import
   |             help: a similar path exists: `crate::prefix_argument::key_value_args::serenity`

For more information about this error, try `rustc --explain E0432`.
error: could not compile `poise` (lib) due to 1 previous error
```
@SkyfallWasTaken
Copy link
Author

looks like serenity_context also got renamed, which is weird because it didn't show up on my cargo clippy 😅

Anyway I'll probably try to fix most of those later

@SkyfallWasTaken
Copy link
Author

SkyfallWasTaken commented Jun 8, 2024

Okay, so I think that's everything! The tests are working anyways

@GnomedDev
Copy link
Member

Thanks for the PR, however I've fixed this up via rebasing and editing the specific commits that brought in the issues.

@GnomedDev GnomedDev closed this Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants