New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix class functions and improve typing #324

Open

gbyesiltas wants to merge 4 commits into segmentio:master from gbyesiltas:fix-class-functions-and-type

gbyesiltas commented Aug 8, 2024 •

edited

Loading

Change list

Now returning the whole client instance instead of spreading it because the functions from the class instance don't work with the spread operator (e.g. client.screen() would complain that it doesn't exist).
Added explicit return types for the useAnalytics hook because it would always be interpreted as {} when used otherwise
Updated the snapshot

gbyesiltas added 4 commits

August 8, 2024 12:14


          now returning the whole class instance to not lose the functions

793af35


          adding explicit typing

401a3fa


          regenerated snapshots

5c822db


          fixed the type

f689899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet