build: do not run lerna build #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alec Jacobs <charles.jacobs@segment.com>
Sabrina0614
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous
yarn buildcommand ranlerna run build, which was causing issues with the release process.For some reason,
lerna run buildwas deletingdist/index.d.tsfiles from the build public plugins, meaning on release that they would no longer include their type definitions.Backstage does not even define a root
yarn buildanymore and@backstage/create-appalso no longer has thislerna run buildstep.For now, just make
yarn buildandyarn build:allequivalent since that is primary requirement for this repo.