Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/auto connect #412

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Fix/auto connect #412

merged 4 commits into from
Jul 7, 2023

Conversation

rin-st
Copy link
Member

@rin-st rin-st commented Jul 7, 2023

Description

Fixes auto connect and hydration error. Removes useAutoConnect hook since auto connect now works without a hook. Please lmk if it is still needed

Additional Information

Related Issues

Closes #391

Your ENS/address: 0xrinat

Copy link
Collaborator

@sverps sverps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup @rin-st

Added two small comments

@technophile-04
Copy link
Collaborator

Also one thing I think now is we can have only maybe as burnerWallet boolean instead of having it as an object and maybe rename it to burnerWalletOnlyLocal?

we will be just needing to update it here :

wallets: burnerConfig.enabled ? [...wallets, burnerWalletConfig({ chains: [appChains.chains[0]] })] : wallets,

and update this :

We have burnerWallet always on hardhat and disabled by default in other chains and if user makes that boolean true it will show on other chains too

@rin-st
Copy link
Member Author

rin-st commented Jul 7, 2023

updated. We should mention changes on #384 after merge

Copy link
Collaborator

@sverps sverps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tysm @rin-st 🙌 It works nicely!!

@technophile-04 technophile-04 merged commit fb3fcd6 into main Jul 7, 2023
1 check passed
@technophile-04 technophile-04 deleted the fix/auto-connect branch July 7, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: autoConnect is not working
4 participants