Skip to content

Commit

Permalink
chore: dockerfile warnings (#301)
Browse files Browse the repository at this point in the history
  • Loading branch information
francisdb authored Aug 27, 2024
1 parent 027245d commit a1b74c4
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 19 deletions.
10 changes: 5 additions & 5 deletions eclipse-temurin/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ FROM eclipse-temurin:${BASE_IMAGE_TAG:-11.0.16.1_1-jdk}

# Env variables
ARG SCALA_VERSION
ENV SCALA_VERSION ${SCALA_VERSION:-2.13.10}
ENV SCALA_VERSION=${SCALA_VERSION:-2.13.10}
ARG SBT_VERSION
ENV SBT_VERSION ${SBT_VERSION:-1.6.2}
ENV SBT_VERSION=${SBT_VERSION:-1.6.2}
ARG USER_ID
ENV USER_ID ${USER_ID:-1001}
ENV USER_ID=${USER_ID:-1001}
ARG GROUP_ID
ENV GROUP_ID ${GROUP_ID:-1001}
ENV GROUP_ID=${GROUP_ID:-1001}

# Install dependencies
# curl for downloading sbt and scala
Expand Down Expand Up @@ -88,4 +88,4 @@ RUN \
## -w /home/sbtuser
WORKDIR /root

CMD sbt
CMD ["sbt"]
4 changes: 2 additions & 2 deletions eclipse-temurin/alpine.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Use a multi-stage build to reduce the size of the final image
ARG BASE_IMAGE_TAG
FROM eclipse-temurin:${BASE_IMAGE_TAG:-21.0.2_13-jdk-alpine} as builder
FROM eclipse-temurin:${BASE_IMAGE_TAG:-21.0.2_13-jdk-alpine} AS builder

ARG SCALA_VERSION=3.4.0
ARG SBT_VERSION=1.9.9
Expand Down Expand Up @@ -88,4 +88,4 @@ RUN \
## -w /home/sbtuser
WORKDIR /root

CMD sbt
CMD ["sbt"]
12 changes: 6 additions & 6 deletions graalvm-ce/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ FROM ghcr.io/graalvm/graalvm-ce:${BASE_IMAGE_TAG:-java11-21.3.0}

# Env variables
ARG SCALA_VERSION
ENV SCALA_VERSION ${SCALA_VERSION:-2.13.10}
ENV SCALA_VERSION=${SCALA_VERSION:-2.13.10}
ARG SBT_VERSION
ENV SBT_VERSION ${SBT_VERSION:-1.6.2}
ENV JAVA_OPTS -XX:+UseG1GC
ENV SBT_VERSION=${SBT_VERSION:-1.6.2}
ENV JAVA_OPTS=-XX:+UseG1GC
ARG USER_ID
ENV USER_ID ${USER_ID:-1001}
ENV USER_ID=${USER_ID:-1001}
ARG GROUP_ID
ENV GROUP_ID ${GROUP_ID:-1001}
ENV GROUP_ID=${GROUP_ID:-1001}

# Install sbt
RUN \
Expand Down Expand Up @@ -77,4 +77,4 @@ RUN \
## -w /home/sbtuser
WORKDIR /root

CMD sbt
CMD ["sbt"]
12 changes: 6 additions & 6 deletions graalvm-community/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ FROM ghcr.io/graalvm/graalvm-community:${BASE_IMAGE_TAG:-21.0.1-ol9}

# Env variables
ARG SCALA_VERSION
ENV SCALA_VERSION ${SCALA_VERSION:-2.13.12}
ENV SCALA_VERSION=${SCALA_VERSION:-2.13.12}
ARG SBT_VERSION
ENV SBT_VERSION ${SBT_VERSION:-1.9.7}
ENV JAVA_OPTS -XX:+UseG1GC
ENV SBT_VERSION=${SBT_VERSION:-1.9.7}
ENV JAVA_OPTS=-XX:+UseG1GC
ARG USER_ID
ENV USER_ID ${USER_ID:-1001}
ENV USER_ID=${USER_ID:-1001}
ARG GROUP_ID
ENV GROUP_ID ${GROUP_ID:-1001}
ENV GROUP_ID=${GROUP_ID:-1001}

# Install sbt
RUN \
Expand Down Expand Up @@ -77,4 +77,4 @@ RUN \
## -w /home/sbtuser
WORKDIR /root

CMD sbt
CMD ["sbt"]

0 comments on commit a1b74c4

Please sign in to comment.