-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sap_swpm: New improved and simplified version #840
base: dev
Are you sure you want to change the base?
Conversation
Signed-off-by: Bernd Finger <bfinger@redhat.com>
Signed-off-by: Bernd Finger <bfinger@redhat.com>
Signed-off-by: Bernd Finger <bfinger@redhat.com>
Signed-off-by: Bernd Finger <bfinger@redhat.com>
Signed-off-by: Bernd Finger <bfinger@redhat.com>
Signed-off-by: Bernd Finger <bfinger@redhat.com>
Signed-off-by: Bernd Finger <bfinger@redhat.com>
Signed-off-by: Bernd Finger <bfinger@redhat.com>
Signed-off-by: Bernd Finger <bfinger@redhat.com>
Signed-off-by: Bernd Finger <bfinger@redhat.com>
Signed-off-by: Bernd Finger <bfinger@redhat.com>
Signed-off-by: Bernd Finger <bfinger@redhat.com>
Note: I successfully tested with ap4s scenarios |
Signed-off-by: Bernd Finger <bfinger@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes needed, while I continue testing.
Signed-off-by: Bernd Finger <bfinger@redhat.com>
Signed-off-by: Bernd Finger <bfinger@redhat.com>
... for better readability Signed-off-by: Bernd Finger <bfinger@redhat.com>
Signed-off-by: Bernd Finger <bfinger@redhat.com>
Signed-off-by: Bernd Finger <bfinger@redhat.com>
... in defaults/main.yml Signed-off-by: Bernd Finger <bfinger@redhat.com>
Signed-off-by: Bernd Finger <bfinger@redhat.com>
Due to the use of global variables in sap_swpm, there appears to be no simple way of giving priority to top level vars over the same variables defined in sap_swpm_templates_install_dictionary. We can also assume that if using sap_swpm_templates_install_dictionary, this is done on purpose and with the intention to use its members with priority over top level variables. Signed-off-by: Bernd Finger <bfinger@redhat.com>
Successfully tested with AP4S scenarios:
on AWS, using the dictionary Note: Variables defined inside the dictionary
If the variable The role is using |
Note: This is WIP. Signed-off-by: Bernd Finger <bfinger@redhat.com>
I am providing an improved and simplified version of the role sap_swpm, with the following features:
inifile.params
using both methods (inifile sections and direct parameter setttings), similar to combining thedefault
andadvanced
modes of the previous version. In the first step (but only if the role parametersap_swpm_inifile_sections_list
is defined), the new sap_swpm version is creating the fileinifile.params
from the inifile sections in the template. Then, if the parametersap_swpm_inifile_parameters_dict
is defined, existing variable definitions can be modified, or additional variables and their settings can be added at the end of the file. This provides maximum flexibility for creating the fileinifile.params
while not increasing the complexity of the logic.sap_swpm_inifile_custom_values_dictionary
(for setting role variables) inside the role, as it was required for the previous modesdefault_templates
andadvanced_templates
. The dictionary can still be used and maintained, by setting certain top level role parameters from dictionary members. Note: You cannot access low level dictionary members using a variable which has been defined in the same task. For defining mid-level variables of a dictionary, you have to use a separate task (e.g.set_fact
) before.inifile.params
parameter input file within a few seconds (using tagsap_swpm_generate_inifile
), without running pre_install steps. This file can then be transferred to managed nodes, to be re-used later, even by the rolesap_swpm
for running unattended installations.sap_hana_install
(parametersap_hana_install_configfile_directory
), the new version of sap_swpm is now checking for an existing installer input file on the managed node (parametersap_swpm_inifile_directory
), not on the control node.