Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_swpm: Remove pids module #720

Closed
wants to merge 5 commits into from

Conversation

berndfinger
Copy link
Member

@berndfinger berndfinger commented Apr 18, 2024

We should better remove the community.general.pids module. Advantages:

Solves #719.

Signed-off-by: Bernd Finger <bfinger@redhat.com>
Relates to sap-linuxlab#716 and sap-linuxlab#719.

Signed-off-by: Bernd Finger <bfinger@redhat.com>
Relates to sap-linuxlab#719.

Signed-off-by: Bernd Finger <bfinger@redhat.com>
Relates to sap-linuxlab#719.

Signed-off-by: Bernd Finger <bfinger@redhat.com>
Copy link
Contributor

@marcelmamula marcelmamula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@berndfinger Tested and it works for sap_swpm, but it breaks recent changes in sap_ha_pacemaker_cluster and ha_cluster roles.

New ASCS/ERS post steps were added that include python3-pip with pexpect for ansible.builtin.expect module in

@ja9fuchs We would need to take these removed python/pip steps and put them into sap_ha role instead.

@marcelmamula
Copy link
Contributor

@berndfinger did you figure out your issues that you mentioned?

@berndfinger
Copy link
Member Author

@berndfinger did you figure out your issues that you mentioned?

None of the issues I had seen were related to this code change but rather to wrong parameter settings.

Copy link
Contributor

@marcelmamula marcelmamula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berndfinger
Copy link
Member Author

Aborting PR due to an error when resolving a merge conflict.

@berndfinger berndfinger deleted the remove-pids-module branch July 5, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants