Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection: Define collection dependency for community.general #717

Closed
wants to merge 1 commit into from

Conversation

berndfinger
Copy link
Member

... in an attempt to solve issue #716.

... in an attempt to solve issue sap-linuxlab#716.

Signed-off-by: Bernd Finger <bfinger@redhat.com>
@marcelmamula
Copy link
Contributor

@berndfinger @Wabri There seems to be something with Checks, datas > data is clear typo, but they all failed.

@Wabri
Copy link
Member

Wabri commented Apr 19, 2024

@marcelmamula hi marcel, the pr was merged yesterday with all the check passed you can see here #718 and in the dev branch there are no references to datas

print("##### Create data #####")

I think the problem is that both actions use the default branch when checkout:

- uses: actions/checkout@v3

You can see the documentation here https://github.com/actions/checkout?tab=readme-ov-file#usage

In order to solve this problem we can set the checkout to the base branch of the pr, or for now just skip it until the dev branch is not merged to the main branch.

@berndfinger
Copy link
Member Author

Closing unmerged, will create a new PR based on version1.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants