Merge pull request #610 from Wabri/feature/improve_workflow

fix(.github/workflows): update all the workflows
sap-linuxlab · Jan 25, 2024 · 65326d2 · 65326d2
2 parents 7920bf0 + 7dff401
commit 65326d2
Show file tree

Hide file tree

Showing 15 changed files with 78 additions and 236 deletions.
diff --git a/.github/workflows/ansible-lint-sap_general_preconfigure.yml b/.github/workflows/ansible-lint-sap_general_preconfigure.yml
@@ -20,24 +20,8 @@ on:
 
 jobs:
   ansible-lint:
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Check out the code
-        uses: actions/checkout@main
-
-      - name: Set up Python 3
-        uses: actions/setup-python@main
+    call-ansible-lint-with-role:
+        uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main
         with:
-          python-version: '3.9'
-
-      - name: Install test dependencies
-        run: |
-          pip3 install ansible==7.5.0
-          pip3 install ansible-compat==3.0.2
-          pip3 install ansible-core==2.14.5
-          pip3 install ansible-lint==6.8.6
+          role: sap_general_preconfigure
 
-      - name: Run ansible-lint
-        working-directory: /home/runner/work/community.sap_install/community.sap_install/roles/sap_general_preconfigure
-        run: ansible-lint
diff --git a/.github/workflows/ansible-lint-sap_ha_install_hana_hsr.yml b/.github/workflows/ansible-lint-sap_ha_install_hana_hsr.yml
@@ -20,24 +20,8 @@ on:
 
 jobs:
   ansible-lint:
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Check out the code
-        uses: actions/checkout@main
-
-      - name: Set up Python 3
-        uses: actions/setup-python@main
+    call-ansible-lint-with-role:
+        uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main
         with:
-          python-version: '3.9'
-
-      - name: Install test dependencies
-        run: |
-          pip3 install ansible==7.5.0
-          pip3 install ansible-compat==3.0.2
-          pip3 install ansible-core==2.14.5
-          pip3 install ansible-lint==6.8.6
+          role: sap_ha_install_hana_hsr
 
-      - name: Run ansible-lint
-        working-directory: /home/runner/work/community.sap_install/community.sap_install/roles/sap_ha_install_hana_hsr
-        run: ansible-lint
diff --git a/.github/workflows/ansible-lint-sap_ha_pacemaker_cluster.yml b/.github/workflows/ansible-lint-sap_ha_pacemaker_cluster.yml
@@ -20,24 +20,9 @@ on:
 
 jobs:
   ansible-lint:
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Check out the code
-        uses: actions/checkout@main
-
-      - name: Set up Python 3
-        uses: actions/setup-python@main
+    call-ansible-lint-with-role:
+        uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main
         with:
-          python-version: '3.9'
+          role: sap_ha_pacemaker_cluster
 
-      - name: Install test dependencies
-        run: |
-          pip3 install ansible==7.5.0
-          pip3 install ansible-compat==3.0.2
-          pip3 install ansible-core==2.14.5
-          pip3 install ansible-lint==6.8.6
 
-      - name: Run ansible-lint
-        working-directory: /home/runner/work/community.sap_install/community.sap_install/roles/sap_ha_pacemaker_cluster
-        run: ansible-lint
diff --git a/.github/workflows/ansible-lint-sap_hana_install.yml b/.github/workflows/ansible-lint-sap_hana_install.yml
@@ -20,24 +20,8 @@ on:
 
 jobs:
   ansible-lint:
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Check out the code
-        uses: actions/checkout@main
-
-      - name: Set up Python 3
-        uses: actions/setup-python@main
+    call-ansible-lint-with-role:
+        uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main
         with:
-          python-version: '3.9'
-
-      - name: Install test dependencies
-        run: |
-          pip3 install ansible==7.5.0
-          pip3 install ansible-compat==3.0.2
-          pip3 install ansible-core==2.14.5
-          pip3 install ansible-lint==6.8.6
+          role: sap_hana_install
 
-      - name: Run ansible-lint
-        working-directory: /home/runner/work/community.sap_install/community.sap_install/roles/sap_hana_install
-        run: ansible-lint
diff --git a/.github/workflows/ansible-lint-sap_hana_preconfigure.yml b/.github/workflows/ansible-lint-sap_hana_preconfigure.yml
@@ -20,24 +20,7 @@ on:
 
 jobs:
   ansible-lint:
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Check out the code
-        uses: actions/checkout@main
-
-      - name: Set up Python 3
-        uses: actions/setup-python@main
+    call-ansible-lint-with-role:
+        uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main
         with:
-          python-version: '3.9'
-
-      - name: Install test dependencies
-        run: |
-          pip3 install ansible==7.5.0
-          pip3 install ansible-compat==3.0.2
-          pip3 install ansible-core==2.14.5
-          pip3 install ansible-lint==6.8.6
-
-      - name: Run ansible-lint
-        working-directory: /home/runner/work/community.sap_install/community.sap_install/roles/sap_hana_preconfigure
-        run: ansible-lint
+          role: sap_hana_preconfigure
diff --git a/.github/workflows/ansible-lint-sap_hypervisor_node_preconfigure.yml b/.github/workflows/ansible-lint-sap_hypervisor_node_preconfigure.yml
@@ -20,24 +20,8 @@ on:
 
 jobs:
   ansible-lint:
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Check out the code
-        uses: actions/checkout@main
-
-      - name: Set up Python 3
-        uses: actions/setup-python@main
+    call-ansible-lint-with-role:
+        uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main
         with:
-          python-version: '3.9'
-
-      - name: Install test dependencies
-        run: |
-          pip3 install ansible==7.5.0
-          pip3 install ansible-compat==3.0.2
-          pip3 install ansible-core==2.14.5
-          pip3 install ansible-lint==6.8.6
+          role: sap_hypervisor_node_preconfigure
 
-      - name: Run ansible-lint
-        working-directory: /home/runner/work/community.sap_install/community.sap_install/roles/sap_hypervisor_node_preconfigure
-        run: ansible-lint
diff --git a/.github/workflows/ansible-lint-sap_install_media_detect.yml b/.github/workflows/ansible-lint-sap_install_media_detect.yml
@@ -20,24 +20,7 @@ on:
 
 jobs:
   ansible-lint:
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Check out the code
-        uses: actions/checkout@main
-
-      - name: Set up Python 3
-        uses: actions/setup-python@main
+    call-ansible-lint-with-role:
+        uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main
         with:
-          python-version: '3.9'
-
-      - name: Install test dependencies
-        run: |
-          pip3 install ansible==7.5.0
-          pip3 install ansible-compat==3.0.2
-          pip3 install ansible-core==2.14.5
-          pip3 install ansible-lint==6.8.6
-
-      - name: Run ansible-lint
-        working-directory: /home/runner/work/community.sap_install/community.sap_install/roles/sap_install_media_detect
-        run: ansible-lint
+          role: sap_install_media_detect
diff --git a/.github/workflows/ansible-lint-sap_maintain_etc_hosts.yml b/.github/workflows/ansible-lint-sap_maintain_etc_hosts.yml
@@ -20,24 +20,7 @@ on:
 
 jobs:
   ansible-lint:
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Check out the code
-        uses: actions/checkout@main
-
-      - name: Set up Python 3
-        uses: actions/setup-python@main
+    call-ansible-lint-with-role:
+        uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main
         with:
-          python-version: '3.9'
-
-      - name: Install test dependencies
-        run: |
-          pip3 install ansible==7.5.0
-          pip3 install ansible-compat==3.0.2
-          pip3 install ansible-core==2.14.5
-          pip3 install ansible-lint==6.8.6
-
-      - name: Run ansible-lint
-        working-directory: /home/runner/work/community.sap_install/community.sap_install/roles/sap_maintain_etc_hosts
-        run: ansible-lint
+          role: sap_maintain_etc_hosts
diff --git a/.github/workflows/ansible-lint-sap_netweaver_preconfigure.yml b/.github/workflows/ansible-lint-sap_netweaver_preconfigure.yml
@@ -20,24 +20,8 @@ on:
 
 jobs:
   ansible-lint:
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Check out the code
-        uses: actions/checkout@main
-
-      - name: Set up Python 3
-        uses: actions/setup-python@main
+    call-ansible-lint-with-role:
+        uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main
         with:
-          python-version: '3.9'
-
-      - name: Install test dependencies
-        run: |
-          pip3 install ansible==7.5.0
-          pip3 install ansible-compat==3.0.2
-          pip3 install ansible-core==2.14.5
-          pip3 install ansible-lint==6.8.6
+          role: sap_netweaver_preconfigure
 
-      - name: Run ansible-lint
-        working-directory: /home/runner/work/community.sap_install/community.sap_install/roles/sap_netweaver_preconfigure
-        run: ansible-lint
diff --git a/.github/workflows/ansible-lint-sap_reusable_workflow.yml b/.github/workflows/ansible-lint-sap_reusable_workflow.yml
@@ -0,0 +1,36 @@
+---
+
+# Workflow for ansible-lint of a role
+
+name: ansible-lint reusable workflow for role
+
+on:
+  workflow_call:
+    inputs:
+      role:
+        required: true
+        type: string
+
+jobs:
+  ansible-lint:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Check out the code
+        uses: actions/checkout@v4
+
+      - name: Set up Python 3
+        uses: actions/setup-python@v5
+        with:
+          python-version: '3.12'
+
+      - name: Install test dependencies
+        run: |
+          pip3 install ansible==9.1.0
+          pip3 install ansible-compat==4.1.11
+          pip3 install ansible-core==2.16.2
+          pip3 install ansible-lint==6.22.2
+
+      - name: Run ansible-lint
+        working-directory: /home/runner/work/community.sap_install/community.sap_install/roles/${{ inputs.role }}
+        run: ansible-lint
diff --git a/.github/workflows/ansible-lint-sap_storage_setup.yml b/.github/workflows/ansible-lint-sap_storage_setup.yml
@@ -20,24 +20,8 @@ on:
 
 jobs:
   ansible-lint:
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Check out the code
-        uses: actions/checkout@main
-
-      - name: Set up Python 3
-        uses: actions/setup-python@main
+    call-ansible-lint-with-role:
+        uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main
         with:
-          python-version: '3.9'
-
-      - name: Install test dependencies
-        run: |
-          pip3 install ansible==7.5.0
-          pip3 install ansible-compat==3.0.2
-          pip3 install ansible-core==2.14.5
-          pip3 install ansible-lint==6.8.6
+          role: sap_storage_setup
 
-      - name: Run ansible-lint
-        working-directory: /home/runner/work/community.sap_install/community.sap_install/roles/sap_storage_setup
-        run: ansible-lint
diff --git a/.github/workflows/ansible-lint-sap_swpm.yml b/.github/workflows/ansible-lint-sap_swpm.yml
@@ -20,24 +20,8 @@ on:
 
 jobs:
   ansible-lint:
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Check out the code
-        uses: actions/checkout@main
-
-      - name: Set up Python 3
-        uses: actions/setup-python@main
+    call-ansible-lint-with-role:
+        uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main
         with:
-          python-version: '3.9'
-
-      - name: Install test dependencies
-        run: |
-          pip3 install ansible==7.5.0
-          pip3 install ansible-compat==3.0.2
-          pip3 install ansible-core==2.14.5
-          pip3 install ansible-lint==6.8.6
+          role: sap_swpm
 
-      - name: Run ansible-lint
-        working-directory: /home/runner/work/community.sap_install/community.sap_install/roles/sap_swpm
-        run: ansible-lint
diff --git a/.github/workflows/ansible-lint-sap_vm_preconfigure.yml b/.github/workflows/ansible-lint-sap_vm_preconfigure.yml
@@ -20,24 +20,8 @@ on:
 
 jobs:
   ansible-lint:
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Check out the code
-        uses: actions/checkout@main
-
-      - name: Set up Python 3
-        uses: actions/setup-python@main
+    call-ansible-lint-with-role:
+        uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main
         with:
-          python-version: '3.12'
-
-      - name: Install test dependencies
-        run: |
-          pip3 install ansible==9.1.0
-          pip3 install ansible-compat==4.1.10
-          pip3 install ansible-core==2.16.2
-          pip3 install ansible-lint==6.22.1
-
-      - name: Run ansible-lint
-        working-directory: /home/runner/work/community.sap_install/community.sap_install/roles/sap_vm_preconfigure
-        run: ansible-lint
+          role: sap_vm_preconfigure
+
diff --git a/.github/workflows/ansible-lint.yml b/.github/workflows/ansible-lint.yml
@@ -16,10 +16,10 @@ jobs:
 
     steps:
       - name: Check out the code
-        uses: actions/checkout@main
+        uses: actions/checkout@v4
 
       - name: Set up Python 3
-        uses: actions/setup-python@main
+        uses: actions/setup-python@v5
         with:
           python-version: '3.12'