Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-271 - LCM Triomics Configuration + Integration Suite Tests #4305

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from

Conversation

SHIV5T3R
Copy link
Member

Closes #4291

Changes proposed in this pull request

  • Added configuration for the initial steps of the pipeline

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.56%. Comparing base (541aa23) to head (59bcfc6).
Report is 52 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4305      +/-   ##
===========================================
- Coverage    87.60%   87.56%   -0.04%     
===========================================
  Files         1383     1383              
  Lines        29875    29875              
===========================================
- Hits         26172    26161      -11     
- Misses        3703     3714      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SHIV5T3R SHIV5T3R marked this pull request as ready for review August 28, 2024 12:45
Copy link
Contributor

@KatyTaylor KatyTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions - up for debate. And maybe we commit this version first and then do the changes later in Y24-266.

Copy link
Member

@andrewsparkes andrewsparkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just suggested changes to the comments in the submission template file.
I assume we'll add a 2nd submission template for the WGS route in another story.

Copy link
Member

@yoldas yoldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have suggested a few changes. The request type name is particularly important as it is visible to the user.

@yoldas
Copy link
Member

yoldas commented Sep 5, 2024

Also merge develop back into your branch to get the updates to make all tests pass.

Copy link
Member

@yoldas yoldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y24-271 - Configuration and integration test for the start of LCM Triomics Pipeline
4 participants