Fix for Incorrect sys.path Sanitization Logic for Linked Directories #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the code for the unit test needed to be adjusted a little bit. This commit should fix it. |
This change now accounts for the interpreter being launched from a linked directory by calling `.resolve()` on existing entries in `sys.path`.
This changes the test to properly capitalize drive letters and introduces a new path separator variable that should resolve any platform-specific path checking in this unit test.
dwoz
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #167.
This change now accounts for the interpreter being launched from a linked directory by calling
.resolve()on existing entries insys.path.