Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix salt_aborted metric lacks a state label #27

Conversation

nicholasmhughes
Copy link
Member

What does this PR do?

See issue for details.

What issues does this PR fix or reference?

Fixes: #26

Previous Behavior

Output looked like this:

salt_aborted 1.0

New Behavior

Now it looks like this:

salt_aborted{state="aaa",state_id="echo includeme"} 1.0

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@nicholasmhughes nicholasmhughes merged commit 14787e8 into salt-extensions:main Feb 22, 2024
17 checks passed
@nicholasmhughes nicholasmhughes deleted the fix-salt_aborted-metric-label branch February 22, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] salt_aborted metric lacks a state label
2 participants