Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(Safe Apps): admin chains with names #1234

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Feat(Safe Apps): admin chains with names #1234

merged 2 commits into from
Sep 20, 2024

Conversation

katspaugh
Copy link
Member

Resolves #984

This PR makes the chain_ids fields in the admin UI display a multiple choice select and it retrieves the allowed chain ids and chain names from the Chains app.

Screenshot 2024-09-19 at 16 07 13

@katspaugh katspaugh requested a review from a team as a code owner September 19, 2024 14:09
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10942810786

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 99.496%

Files with Coverage Reduction New Missed Lines %
safe_apps/admin.py 2 97.18%
Totals Coverage Status
Change from base Build 10923497268: -0.2%
Covered Lines: 1185
Relevant Lines: 1191

💛 - Coveralls

@katspaugh katspaugh merged commit 04dbd17 into main Sep 20, 2024
17 checks passed
@katspaugh katspaugh deleted the admin-chain_ids branch September 20, 2024 08:32
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chain ids in Safe Apps
4 participants