Pin web3 to 6.20.2 #1231
Merged
Pin web3 to 6.20.2 #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10900324207Details
💛 - Coveralls |
PooyaRaki
approved these changes
Sep 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our
django-checkjob is currently failing after install (example). This stems from the related version of the web3 package for safe-eth-py. The offending error is:When transitioning from version 6 to 7, web3 renamed some middleware, including
get_poa_middleware. Our safe-eth-py package has yet to migrate to version 7, however. It therefore tries to import the non-existentget_poa_middleware.This pins the web3 package in accordance with the requirements of safe-eth-py.
Changes