Disable ssimulacra2's rayon feature #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good, could you please open an issue so we can investigate if we can improve rayon later? |
|
@lu-zero Can you explain what you mean? The rayon feature in ssimulacra2 isn't bad or anything, but we have a better threading mechanism in this crate |
|
Ideally we can make so the rayon in the crate library cooperates better with downstream crates from what you found out :) |
|
I see. I opened rust-av/ssimulacra2#18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21.
We have our own threading mechanism, adding rayon on top of that is unnecessary and less efficient1.
This also makes the CPU usage a lot more predictable. Using
-f 8on a machine with 16 logical cores will show close to 50% CPU usage. With rayon, this was always more than expected (~70% in this example).Footnotes
On my two machines, normalizing for CPU usage will always result in higher FPS without rayon. ↩